GEOPY-2449: Create UI and Driver for the classification of EM anomalies#335
GEOPY-2449: Create UI and Driver for the classification of EM anomalies#335domfournier merged 25 commits intodevelopfrom
Conversation
github-actions
bot
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #335 +/- ##
===========================================
- Coverage 91.39% 91.06% -0.34%
===========================================
Files 114 117 +3
Lines 6216 6400 +184
Branches 758 774 +16
===========================================
+ Hits 5681 5828 +147
- Misses 342 380 +38
+ Partials 193 192 -1
🚀 New features to boost your workflow:
|
| with Workspace(self.params.simulation_files[0], mode="r") as ws: | ||
| survey = fetch_survey(ws) | ||
| if survey.channels is None: | ||
| raise GeoAppsError( |
There was a problem hiding this comment.
We are currently using GeoAppsError to re-format errors raised during input validation. We should probably make a distinction between errors we raise during validation and those we raise while executing the driver.
There was a problem hiding this comment.
I don't get what you mean. GeoAppsError is used to return smaller messages to the user, regardless of where it is.
There was a problem hiding this comment.
yeah, but we use it to collect validations as well. We should probably use a different Error type for the validation and keep GeoAppsError for these internal checks.
There was a problem hiding this comment.
We could, but that requires to change the try: except in the base Driver. You can create a new issue if you think it's important.
2 participants
GEOPY-2449 - Create UI and Driver for the classification of EM anomalies